Repository navigation
fix(sop): keep streamed node positions when applying edits - #1162
Merged
Robert0622 merged 1 commit intoNov 21, 2026
Merged
Robert0622 merged 1 commit into
Robert0622 merged 1 commit into
Conversation
Collaborator
Author
|
在
新增回归用例在 #1154 上复现了画布异常,应用本 PR 后通过。编排相关 webtest 和 Go Web 定向测试也通过。 |
Robert0622
merged commit Nov 21, 2026
c9580a8
into
codex/fix-sop-orchestrator-role-settings
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1154. This PR targets its branch so the diff contains the canvas fix and its regression test.
Problem
#1154 fixes the shared-session HTTP 409 on the second orchestrator message. A later edit can still fail after the model returns a valid draft. During streaming, the canvas assigns positions to new nodes. If the final draft omits a position for an already drawn node, replacing that node loses its coordinates and the renderer throws
Cannot read properties of undefined (reading 'x').Changes
Verification
d58a85aand the canvas exception on the Fix role binding and settings in the SOP orchestrator #1154 merge previewe34ab530.